Merged
Conversation
…ure consistent sourcing of updates while developing
…the error by making units in legend conditional on their existence
Fix 142 add dm profile
…ngs$baseline_values-to-create_nepexplorer_app fix: added argument for baseline value.
…ngs tab and into selectize within module
…ttings #136 move control of fold change labs in patient profile out of mappi…
…SafetyGraphics/nepExplorer into 145-add-packagedowngithub-pages
…SafetyGraphics/nepExplorer into 145-add-packagedowngithub-pages
…SafetyGraphics/nepExplorer into 145-add-packagedowngithub-pages
…SafetyGraphics/nepExplorer into 145-add-packagedowngithub-pages
…SafetyGraphics/nepExplorer into 145-add-packagedowngithub-pages
…-pages 145 add packagedowngithub pages
…://github.com/SafetyGraphics/nepExplorer into 108-add-buncreatinine-chart
…://github.com/SafetyGraphics/nepExplorer into 108-add-buncreatinine-chart
…tyGraphics/nepExplorer into 108-add-buncreatinine-chart
…tyGraphics/nepExplorer into 108-add-buncreatinine-chart
…tyGraphics/nepExplorer into 108-add-buncreatinine-chart
save_adlb - add BUN/CREAT updates meta_nepExplorer - add BUN/CREAT updates and tidy up ALB/CREAT ratio patient_profile_mod - update for drawBunCreat use the BUN/CREAT ratio patient_profile_charts - update for drawBunCreat use the BUN/CREAT ratio create_nepexplorer_app - add BUN/CREAT mapping examples/safetyGraphics_demo_app - add the ALB/CREAT and BUN/CREAT records and update units for associated tests examples/standalone_app - add BUN/CREATE mapping man/drawBunCreat - add documentation
- Warning: file=inst/examples/safetyGraphics_demo_app.R,line=14,col=3,[object_length_linter] Variable and function names should not be longer than 30 characters. Warning: file=R/patient_profile_charts.R,line=410,col=1,[trailing_blank_lines_linter] Trailing blank lines are superfluous. Warning: file=R/patient_profile_mod.R,line=104,col=51,[trailing_whitespace_linter] Trailing whitespace is superfluous.
Prerelease clean up
Contributor
Author
|
I will redeploy the demo app once we release |
pburnsdata
requested review from
Lovemore-Gakava and
elimillera
and removed request for
lgakava
… in vignette to match values in the example datasets
Contributor
Lovemore-Gakava
left a comment
Lovemore-Gakava
left a comment
There was a problem hiding this comment.
@pburnsdata - great work! a few last minute suggestions.
Contributor
Author
|
Thank you so much @Lovemore-Gakava, those were fantastic catches. Went through and made updates based on each one. I also knocked out #156 while I was in there. Let me know if I missed anything!! |
Contributor
|
Thank you for the updates! Just one minor change needed in the vignette - we need to update the reference to point to the master branch, and then we're good to go! 🖥️ |
elimillera
approved these changes
Mar 12, 2025
Contributor
elimillera
left a comment
elimillera
left a comment
There was a problem hiding this comment.
Looks great, thanks so much @pburnsdata
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reviewer verifies that:
DESCRIPTIONandNEWS.mdfile updatedREADME.md, vignettes,NEWS.md,DESCRIPTION)R CMD checkwarnings found by the CI/CD build stage were reviewed